Skip to content

Conversation

@ChelseaChanu
Copy link
Contributor

@ChelseaChanu ChelseaChanu commented Feb 22, 2023

Fixes #2999.

Modifications

Describe the modifications you've done.

literal string comparision changed in 4 lines in handle(HttpExchange httpExchange) method in GrpcClientHandler.java

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3237 (6a4aec5) into master (a320625) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 6a4aec5 differs from pull request most recent head 1cc3b8a. Consider uploading reports for the commit 1cc3b8a to get more accurate results

@@            Coverage Diff            @@
##             master    #3237   +/-   ##
=========================================
  Coverage     13.04%   13.04%           
  Complexity     1155     1155           
=========================================
  Files           549      549           
  Lines         28732    28732           
  Branches       2848     2848           
=========================================
  Hits           3749     3749           
  Misses        24660    24660           
  Partials        323      323           
Impacted Files Coverage Δ
...tmesh/runtime/admin/handler/GrpcClientHandler.java 4.39% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 changed the title [ISSUE 3#2999]literal string comparison changed in 3 lines [ISSUE #2999]Method makes literal string comparisons passing the literal as an argument [GrpcClientHandler] Feb 22, 2023
@xwm1992 xwm1992 merged commit 5c63ab1 into apache:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Method makes literal string comparisons passing the literal as an argument [GrpcClientHandler]

2 participants