fix GEARPUMP-41 check akka.scheduler.tick-duration on Windows#4
Conversation
|
+1 |
| // Minimum supported akka.scheduler.tick-duration on Windows is 10ms | ||
| val duration = config.getInt(Constants.AKKA_SCHEDULER_TICK_DURATION) | ||
| val updatedConf = if (akka.util.Helpers.isWindows && duration < 10) { | ||
| LOG.warn(s"akka.scheduler.tick-duration on Windows must be larger than 10ms, set to 10ms") |
There was a problem hiding this comment.
better use Constants.AKKA_SCHEDULER_TICK_DURATION in the LOG.
huafengw
force-pushed
the
fix_GEARPUMP-41
branch
from
5d3d0be to
62a8795
Compare
| if (!akka.util.Helpers.isWindows) { | ||
|
|
||
| // Change the akka.scheduler.tick-duration to 10ms for Linux or Mac | ||
| // Change the akka.scheduler.tick-duration to 1 ms for Linux or Mac |
There was a problem hiding this comment.
I think it's better to load window specific or linux specific configurations here than later to decide whether a config belongs to windows or linux
There was a problem hiding this comment.
That's different situations.
When the cluster config is loaded, it will check the environment and akka.scheduler.tick-duration to make sure the ActorSystem can be launched correctly.
However, when launching an application, the Config of Executor's ActorSytem is composed of Worker's cluster config and application's config, and Worker's akka.scheduler.tick-duration could be overwrote by a wrong value. So another check here is needed.
|
+1 |
huafengw
force-pushed
the
fix_GEARPUMP-41
branch
from
62a8795 to
ccf318f
Compare
Author: Kam Kasravi <kamkasravi@yahoo.com> Closes apache#4 from kkasravi/GEARPUMP-187.
4 participants
No description provided.