Skip to content

[GOBBLIN-1019] Change jcenter url to https#2865

Closed
jack-moseley wants to merge 1 commit intoapache:masterfrom
jack-moseley:jcenter-https
Closed

[GOBBLIN-1019] Change jcenter url to https#2865
jack-moseley wants to merge 1 commit intoapache:masterfrom
jack-moseley:jcenter-https

Conversation

@jack-moseley
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #2865 into master will increase coverage by 41.64%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2865       +/-   ##
=============================================
+ Coverage       4.1%   45.75%   +41.64%     
- Complexity      747     9104     +8357     
=============================================
  Files          1917     1917               
  Lines         72131    72131               
  Branches       7956     7956               
=============================================
+ Hits           2961    33002    +30041     
+ Misses        68851    36102    -32749     
- Partials        319     3027     +2708
Impacted Files Coverage Δ Complexity Δ
...gobblin/service/monitoring/JobStatusRetriever.java 0% <0%> (ø) 2% <0%> (+2%) ⬆️
...ata/management/copy/hive/HivePartitionFileSet.java 0.95% <0%> (+0.95%) 1% <0%> (+1%) ⬆️
...ain/java/org/apache/gobblin/runtime/TaskState.java 81.97% <0%> (+1.16%) 32% <0%> (ø) ⬇️
...pache/gobblin/runtime/GobblinMultiTaskAttempt.java 56.3% <0%> (+1.35%) 27% <0%> (+2%) ⬆️
...ava/org/apache/gobblin/runtime/MultiConverter.java 83.6% <0%> (+1.63%) 9% <0%> (+1%) ⬆️
...rg/apache/gobblin/runtime/FsDatasetStateStore.java 73.8% <0%> (+1.78%) 35% <0%> (+1%) ⬆️
...a/org/apache/gobblin/cluster/SingleTaskRunner.java 1.85% <0%> (+1.85%) 1% <0%> (+1%) ⬆️
.../java/org/apache/gobblin/runtime/TaskExecutor.java 45.35% <0%> (+2.73%) 9% <0%> (+1%) ⬆️
...apache/gobblin/source/jdbc/SqlServerExtractor.java 4.41% <0%> (+4.41%) 3% <0%> (+3%) ⬆️
...ava/org/apache/gobblin/http/ApacheHttpRequest.java 5.55% <0%> (+5.55%) 1% <0%> (+1%) ⬆️
... and 1110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b0741...a1b4ae4. Read the comment docs.

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM.

@asfgit asfgit closed this in 357d1db Jan 13, 2020
haojiliu pushed a commit to haojiliu/incubator-gobblin that referenced this pull request Apr 9, 2020
Closes apache#2865 from jack-moseley/jcenter-https
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Apr 26, 2020
Closes apache#2865 from jack-moseley/jcenter-https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants