Commit tsfile-go #124
Open
Commit tsfile-go #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi, daihuia, this is indeed a very good job, but I have a question whether the implementation of this Go version has a performance improvement compared to the Java implementation of the same version? |
NiklasMerz
reviewed
Oct 4, 2021
Member
NiklasMerz
left a comment
NiklasMerz
left a comment
There was a problem hiding this comment.
I look quickly at the code and found a few bigger commented out code blocks, that could be removed for better readabilty. Please correct me if I am wrong.
Another question: Why is this not a Go Module and built with an old Go version on Travis? Newer Go versions (mine is 1.16) expect a go.mod file and module support. Even with putting the go files in my GOPATH it won't build
Engine_WriteTsPerfTest.go:30:2: cannot find package "tsfile/common/constant" in any of:
/usr/local/go/src/tsfile/common/constant (from $GOROOT)
/home/niklas/go/src/tsfile/common/constant (from $GOPATH)
Engine_GenFilePerfTest.go:29:2: cannot find package "tsfile/common/log" in any of:
/usr/local/go/src/tsfile/common/log (from $GOROOT)
/home/niklas/go/src/tsfile/common/log (from $GOPATH)
TsFileSequenceReader.go:28:2: cannot find package "tsfile/encoding/decoder" in any of:
/usr/local/go/src/tsfile/encoding/decoder (from $GOROOT)
/home/niklas/go/src/tsfile/encoding/decoder (from $GOPATH)
Engine_PerfTest.go:26:2: cannot find package "tsfile/timeseries/filter" in any of:
/usr/local/go/src/tsfile/timeseries/filter (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/filter (from $GOPATH)
Engine_PerfTest.go:27:2: cannot find package "tsfile/timeseries/filter/operator" in any of:
/usr/local/go/src/tsfile/timeseries/filter/operator (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/filter/operator (from $GOPATH)
Engine_PerfTest.go:28:2: cannot find package "tsfile/timeseries/query" in any of:
/usr/local/go/src/tsfile/timeseries/query (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/query (from $GOPATH)
Engine_PerfTest.go:29:2: cannot find package "tsfile/timeseries/query/engine" in any of:
/usr/local/go/src/tsfile/timeseries/query/engine (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/query/engine (from $GOPATH)
Engine_PerfTest.go:30:2: cannot find package "tsfile/timeseries/read" in any of:
/usr/local/go/src/tsfile/timeseries/read (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/read (from $GOPATH)
TsFileSequenceReader.go:31:2: cannot find package "tsfile/timeseries/read/reader/impl/basic" in any of:
/usr/local/go/src/tsfile/timeseries/read/reader/impl/basic (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/read/reader/impl/basic (from $GOPATH)
Engine_WriteTsPerfTest.go:32:2: cannot find package "tsfile/timeseries/write/sensorDescriptor" in any of:
/usr/local/go/src/tsfile/timeseries/write/sensorDescriptor (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/write/sensorDescriptor (from $GOPATH)
Engine_WriteTsPerfTest.go:33:2: cannot find package "tsfile/timeseries/write/tsFileWriter" in any of:
/usr/local/go/src/tsfile/timeseries/write/tsFileWriter (from $GOROOT)
/home/niklas/go/src/tsfile/timeseries/write/tsFileWriter (from $GOPATH)
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
Member
There was a problem hiding this comment.
This file has no test in the name.
| } | ||
| } | ||
|
|
||
| var is_comment bool = false |
Member
There was a problem hiding this comment.
Can this variable be in loadItem?
| offset := pos + width - 1 | ||
| for i := 0; i < width; i++ { | ||
| index := offset - i | ||
| //value = setIntN(value, i, getByteN(data[index/8], index)) |
| } | ||
|
|
||
| func WriteLongLittleEndianPaddedOnBitWidth(value int64, out *bytes.Buffer, bitWidth int) { | ||
| //paddedByteNum := (bitWidth + 7) / 8; |
| return buffer.Bytes() | ||
| } | ||
|
|
||
| //func Int64ToByteLittleEndian(num int64) []byte { |
| if valueCount == 0 { | ||
| aa := []byte{24} | ||
| v.timeBuf.Write(aa) | ||
| //s.timeBuf.Write(utils.BoolToByte(true)) |
| return t.DataPointSli | ||
| } | ||
|
|
||
| //func PushBack(t *TsRecord, tuple dataPoint.DataPoint) { |
| value int32 | ||
| } | ||
|
|
||
| //func (d *DataPoint) Write(v []byte) ([]byte,error) { |
| if pageHeaderErr != nil { | ||
| log.Error("init pageHeader error: ", pageHeaderErr) | ||
| } | ||
| // write pageheader to pageBuf |
| //start_edit wangcan 2018-10-15 | ||
| //if contain, _ := utils.MapContains(r.dataSeriesWriters, sd.GetSensorId()); !contain { | ||
| _, contain := r.dataSeriesWriters[sd.GetSensorId()] | ||
| if !contain { |
neuyilan
added a commit
to neuyilan/iotdb
that referenced
this pull request
Mar 10, 2022
Merge 0.12.3 1213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.