Skip to content

fix recover endTime set bug (affect 0.10.0-SNAPSHOT)#1286

Merged
qiaojialin merged 6 commits intomasterfrom
enhance_wal
May 29, 2020
Merged

fix recover endTime set bug (affect 0.10.0-SNAPSHOT)#1286
qiaojialin merged 6 commits intomasterfrom
enhance_wal

Conversation

@qiaojialin
Copy link
Copy Markdown
Member

@qiaojialin qiaojialin commented May 29, 2020

When meet error when reading logs, we need to retain already recovered data in the tmp memtable.

When recover the last unclosed sequence file, we do not set the endtime. Then newly write data will all go into this new seq tsfile.

When recover, some overlapped chunk groups will be skipped.

@qiaojialin qiaojialin changed the title enhance wal fix recover endTime set bug (imported in 0.10.0-SNAPSHOT) May 29, 2020
@qiaojialin qiaojialin changed the title fix recover endTime set bug (imported in 0.10.0-SNAPSHOT) fix recover endTime set bug (affect 0.10.0-SNAPSHOT) May 29, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@qiaojialin qiaojialin merged commit 7221a87 into master May 29, 2020
@qiaojialin qiaojialin deleted the enhance_wal branch May 29, 2020 12:36
Copy link
Copy Markdown
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants