Refactor the execution path of InsertTabletPlan#1361
Merged
qiaojialin merged 9 commits intomasterfrom Jun 16, 2020
Merged
Conversation
qiaojialin
approved these changes
Jun 15, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
qiaojialin
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
InsertTabletPlandoes not follow the same execution path like other plans, and also have very different return type from others, which caused trouble in the distributed version to process them in a uniformed way.I changed the execution path to let
InsertTabletPlanalso go intoexecuteNonQuery()and wrap the TSStatus in an exception so the inner calls can return void like many other methods.