[IOTDB-897] Remove duplicate maven plugin in module tsfile and website#1737
[IOTDB-897] Remove duplicate maven plugin in module tsfile and website#1737yuqi1129 wants to merge 1 commit intoapache:masterfrom
Conversation
jixuan1989
left a comment
jixuan1989
left a comment
There was a problem hiding this comment.
have you tried to run on the modified codebase (especially for the site module)?
| </distributionManagement> | ||
| <build> | ||
| <plugins> | ||
| <!-- copy source codes into vue required folders--> |
There was a problem hiding this comment.
Hi, why you thought this is duplicated...
have you tried mvn package -pl site -P site ?
There was a problem hiding this comment.
You are right, i mistake it
| </archive> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> |
There was a problem hiding this comment.
this plugin is for generating hadoop-tsfile-0.11.0-SNAPSHOT-jar-with-dependencies.jar file, which includes all dependencies for using hdfs and tsfile.
If the user uses maven, indeed it is useless, but for users who are not use maven, I think it is useful (or someone who uses maven but there are version conflicts for hadoop dependencies).
So, I have no idea about whether to remove this plugin? either is ok.
What do you think?
There was a problem hiding this comment.
Ok, if hadoop-tsfile-0.11.0-SNAPSHOT-jar-with-dependencies.jar is needed somewhere, i do think there is no enough reason to remove it.
Thanks for your kindly review~
| <dependency> | ||
| <groupId>org.apache.iotdb</groupId> | ||
| <artifactId>tsfile</artifactId> | ||
| <version>0.11.0-SNAPSHOT</version> |
|
This pull pull is mark as invalid, close it |
2 participants
No description provided.