[IOTDB-507] Add zeppelin-interpreter module#1739
Merged
kr11 merged 9 commits intoapache:masterfrom Nov 19, 2020
Merged
Conversation
Co-Authored-By: Jialin Qiao <qjl16@mails.tsinghua.edu.cn>
HTHou
requested changes
Oct 10, 2020
Comment on lines
+46
to
+53
| public class IoTDBInterpreter extends Interpreter { | ||
|
|
||
| private IoTDBConnectionException connectionException; | ||
| private Session session; | ||
|
|
||
| public IoTDBInterpreter(Properties property) { | ||
| super(property); | ||
| } |
Contributor
There was a problem hiding this comment.
Please follow the format of other java files. Or use .checkstyle to do the format check.
Comment on lines
+1
to
+4
| [ | ||
| { | ||
| "group": "iotdb", | ||
| "name": "iotodb", |
Contributor
There was a problem hiding this comment.
This file also needs a license header.
Comment on lines
+1
to
+4
| package org.apache.zeppelin.iotdb; | ||
| import java.util.Properties; | ||
| import org.apache.zeppelin.interpreter.InterpreterResult; | ||
| import org.junit.After; |
Contributor
There was a problem hiding this comment.
Add license header and reformat.
|
|
||
| @Test | ||
| public void testNonQuery() { | ||
| for(int i=0;i<100;i++){ |
Contributor
There was a problem hiding this comment.
Suggested change
| for(int i=0;i<100;i++){ | |
| for (int i = 0;i < 100; i++) { |
# Conflicts: # pom.xml
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.