Skip to content

[IOTDB-17] add english doc#18

Merged
jixuan1989 merged 38 commits intomasterfrom
doc
Feb 25, 2019
Merged

[IOTDB-17] add english doc#18
jixuan1989 merged 38 commits intomasterfrom
doc

Conversation

@MyXOF
Copy link
Member

@MyXOF MyXOF commented Jan 22, 2019

No description provided.

@jixuan1989
Copy link
Member

there are some Chineses left. do we fix them now or after merging?

Copy link
Contributor

@wujysh wujysh Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just paste the results as plain text in code block to the documentation. These screenshots will cause the documentation hard to maintain and that is also not elegant in style (font, size, background color, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we will use plain text instead of picture in future document.

@jixuan1989
Copy link
Member

Can we merge this PR? @MyXOF

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here is my recommendation.

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd phase review...

@MyXOF
Copy link
Member Author

MyXOF commented Feb 22, 2019

https://issues.apache.org/jira/browse/IOTDB-17 should be solved

@MyXOF MyXOF changed the title add english doc [IOTDB-17] add english doc Feb 22, 2019
@jixuan1989
Copy link
Member

2nd phase review...

fixed.

@jixuan1989 jixuan1989 merged commit bd30ea8 into master Feb 25, 2019
neuyilan referenced this pull request in neuyilan/iotdb May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments