[IOTDB-152]return data type in TSExecuteStatementResp#294
Merged
qiaojialin merged 3 commits intomasterfrom Jul 26, 2019
Merged
Conversation
qiaojialin
reviewed
Jul 23, 2019
qiaojialin
approved these changes
Jul 25, 2019
jixuan1989
approved these changes
Jul 25, 2019
Member
jixuan1989
left a comment
jixuan1989
left a comment
There was a problem hiding this comment.
+1.
One more question, how much improvement after this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing the query statement, after sending executeStatement request to server and return the execResp, the client send several TSFetchMetadata requests to server for fetching data types of the query columns. So we can return dataTypes in executeStatement request to avoid the following fetchmetaData requests.
Thank Rui Lei for discovering this problem.