Merged
Conversation
Added sha512 code for binary package. Changed version to 0.8.0-SNAPSHOT.
qiaojialin
approved these changes
Jul 26, 2019
jixuan1989
reviewed
Jul 26, 2019
| See https://issues.apache.org/jira/browse/MNG-5454 sigh. | ||
| --> | ||
| <configuration combine.self="append"> | ||
| <finalName>apache-iotdb-${project.version}-incubating</finalName> |
Member
There was a problem hiding this comment.
Oh, now I get what Justin means... just add "incubating" here is fine..
Contributor
Author
There was a problem hiding this comment.
yeah.. therefore I changed the name of the module back to "iotdb-parent" which is more standard : )
Member
|
Hi, I tried this branch but after running |
Contributor
Author
|
@jixuan1989 you have to use |
jixuan1989
approved these changes
Jul 26, 2019
Member
jixuan1989
left a comment
jixuan1989
left a comment
There was a problem hiding this comment.
+1. Learned a lot!
And because the generated binary file is changed, I will modify the dockerfile quickly in a new PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed "build" module and moved this to parent pom.
Renamed parent pom without incubating.
Added incubating artefact names in assembly plugin.
Added SHA512 for all artefacts.
Big props to @chrisdutz for his support!