Used to change Magic String to last version#337
Merged
jixuan1989 merged 1 commit intoapache:masterfrom Aug 21, 2019
Merged
Conversation
jixuan1989
requested changes
Aug 13, 2019
Member
jixuan1989
left a comment
jixuan1989
left a comment
There was a problem hiding this comment.
I think the magic number should be TsFilev0.9.0 without SNAPSHOT.
Besides, we need to provide some logic to make it compatible with other version (e.g., v0.8.0):
- maintain a compatible versions list (now, we only have 0.8.0);
- when reading data (i.e.,checkMagicNumer), if the version is compatible, then do not throw exception, others throw an exception
- In the future, we can provide scripts to upgrade the format of incompatible files.
Contributor
Author
|
@jixuan1989 Thanks, it may take me some days to finish it. |
Member
|
Hi Zhu, can you just remove SNAPSHOT in this PR? |
Contributor
Author
|
@jixuan1989 Have changed it. |
Member
|
Hi Zhu, Jialin and I have a discussion and record them on the JIRA: So, can you just change this PR by:
If you want, you can follow the idea on the JIRA to add compatibility feature. |
code optimization.
Genius-pig
changed the title
Genius-pig
changed the title
Contributor
Author
|
@jixuan1989 Have done and fix some grammar mistakes. |
jixuan1989
approved these changes
Aug 21, 2019
RYH61
pushed a commit
to RYH61/iotdb
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used to Change Magic String to last version. If you want to know more about it, saw this.