[IOTDB-172]fix a bug of TsFileResource updateTime #347
Merged
jixuan1989 merged 3 commits intoapache:masterfrom Aug 22, 2019
LeiRui:ResourceUpdateTime
Merged
[IOTDB-172]fix a bug of TsFileResource updateTime #347jixuan1989 merged 3 commits intoapache:masterfrom LeiRui:ResourceUpdateTime
jixuan1989 merged 3 commits intoapache:masterfrom
LeiRui:ResourceUpdateTime
Conversation
Member
|
please add ut to cover this case |
Contributor
Author
added |
Member
|
Hi, is there an jira issue attached this PR? |
jt2594838
approved these changes
Aug 22, 2019
| } | ||
|
|
||
| @Deprecated | ||
| public void updateTime(String deviceId, long time) { |
Contributor
There was a problem hiding this comment.
You may just remove this method.
Contributor
Author
Added. See IOTDB-172. |
remove useless `updateTime` method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description:
When recovering a TsFile's
device -> start timeanddevice -> end timemap and the TsFile's resource file happens not to exist, the TsFile itself will be read to update the start and end time map instead. It is implemented byTsFileRecoverPerformer.recoveras follows:The
updateTimefunction uses the first-coming value as the startTime:So when root.vehicle.d0 has a chunkgroup of chunkMetadata listed as:
s3: startTime=3000, endTime=10000;
s1: startTime=1000, endTime=10000;
s2: startTime=2000, endTime=10000;
By the current code, the updated start time will be the first coming 3000, which is not correct.
By the way, I also change
updateTimeinLogReplayer.replayLogstoupdateStartTimeandupdateEndTime. If there is something I haven't noticed, please tell me.