Conversation
Contributor
|
Hi, Thanks for your work! This reimplementation is awesome and I'm looking forward to have a try! |
Contributor
SilverNarcissus
left a comment
SilverNarcissus
left a comment
There was a problem hiding this comment.
Only minor issues, please have a look
tsfile/src/main/java/org/apache/iotdb/tsfile/common/conf/TSFileConfig.java
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/sync/sender/transfer/DataTransferManager.java
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/sync/sender/transfer/DataTransferManager.java
Show resolved
Hide resolved
SilverNarcissus
approved these changes
Oct 29, 2019
Contributor
SilverNarcissus
left a comment
SilverNarcissus
left a comment
There was a problem hiding this comment.
I think this can be merged soon :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating the engine, the sync module is re-implemented, and the function is the same as that of the original version. The following changes have been made in the way of implementation:
Loading data at the receiving end adopts the method of cooperating with merge function, which separates the process of data file transmission and file loading.
The synchronization of deletion and update operations is supported.
Adding the option that the sender can choose to storage groups whose data files need to be synced.
jira link: https://issues.apache.org/jira/browse/IOTDB-198