[IOTDB-18] Improve startup script compatible for jdk11#39
Merged
jixuan1989 merged 2 commits intoapache:masterfrom Feb 9, 2019
Merged
[IOTDB-18] Improve startup script compatible for jdk11#39jixuan1989 merged 2 commits intoapache:masterfrom
jixuan1989 merged 2 commits intoapache:masterfrom
Conversation
jixuan1989
requested changes
Feb 2, 2019
Member
jixuan1989
left a comment
There was a problem hiding this comment.
seems this PR does not solve the problem that java version is shown as 11+28...
jixuan1989
approved these changes
Feb 9, 2019
Member
jixuan1989
left a comment
There was a problem hiding this comment.
I will merge this PR and then go on to fix issue IOTDB-18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested on Mac for jdk8, jdk11 and openjdk11, on windows for jdk8, jdk11 and openjdk11
Especially,openjdk11 is downloaded from http://jdk.java.net/11/
java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)