Skip to content

Conversation

@jixuan1989
Copy link
Member

  • But retain the constrain that jdk<1.8u40 will be forbidden.
  • add Apache rat for .checkstyle file.

IOTDB_JMX_OPTS="$IOTDB_JMX_OPTS -Xloggc:${IOTDB_HOME}/gc.log"
fi

if [ "$MAJOR_VERSION" -ne "8" ] && [ "$MAJOR_VERSION" -ne "11" ] ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you remove this check? It seems iotdb only supports jdk8,11 and 13? What if user run iotdb with jdk7 or 9?
Besides, iotdb-env.sh only works for mac and linux, how about windows platform?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 7 will be forbidden by

if [ "$JVM_VERSION" \< "1.8" ] && [ "$JVM_PATCH_VERSION" -lt 40 ] ; then
    echo "IoTDB requires Java 8u40 or later."
    exit 1;
fi

I do not try whether JDK9 is supported.

If we maintain the version check, we have to modify the code like :

if [ "$MAJOR_VERSION" -ne "8" ] && [ "$MAJOR_VERSION" -ne "11" ] && [ "$MAJOR_VERSION" -ne "13" ]  ; then

And now JDK 14 is coming, we need to modify once again:

if [ "$MAJOR_VERSION" -ne "8" ] && [ "$MAJOR_VERSION" -ne "11" ] && [ "$MAJOR_VERSION" -ne "13" ] && [ "$MAJOR_VERSION" -ne "14" ]   ; then

I will try JDK 9 and 10. If they are supported, I think we can remove this check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried JDK9 and JDK10 using OpenJDK Docker image, and IoTDB supports both of them. Therefore, I think removing the code snippet is fine.

@jt2594838 jt2594838 merged commit c90b5fc into master Oct 22, 2019
@qiaojialin qiaojialin deleted the remove_jdk_detect branch February 29, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants