[IOTDB-294]online upgrade from v0.8.0 to current version#467
Merged
Conversation
jt2594838
requested changes
Oct 24, 2019
fanhualta
requested changes
Oct 25, 2019
fanhualta
requested changes
Nov 6, 2019
| tsfilePathBefore + DOT_SEPERATOR + tsfilePathAfter + DOT_SEPERATOR | ||
| + UpgradeCheckStatus.AFTER_UPGRADE_FILE, upgradePostion); | ||
| } catch (IOException e) { | ||
| logger.error("generate upgrade file failed, the file to be upgraded:{}", tsfilePathBefore); |
Contributor
There was a problem hiding this comment.
When the upgrade occurs an error, you just throw an Exception and move the incomplete file to the data directory?
Contributor
Author
There was a problem hiding this comment.
in recovery process, system will remove the imcomplete tsfile
Contributor
There was a problem hiding this comment.
When it occurs in the running of the system, the system engine may read this file which lead to errors.
jt2594838
requested changes
Nov 6, 2019
| oldVersionTsfileDirs.add("/Users/tianyu/incubator-iotdb/data/data/sequence/root.group_10"); | ||
| newVersionTsfileDirs.add("/Users/tianyu/incubator-iotdb/data/data/sequence/root.group_8"); | ||
| for (int i = 0; i < oldVersionTsfileDirs.size(); i++) { | ||
| updateTsfiles(oldVersionTsfileDirs.get(i), newVersionTsfileDirs.get(i)); |
Contributor
There was a problem hiding this comment.
How about making this a real tool.
Contributor
Author
There was a problem hiding this comment.
good idea,I will make it a sh script then.
EJTTianYu
changed the title
jt2594838
approved these changes
Nov 7, 2019
jt2594838
requested changes
Nov 7, 2019
|
|
||
| public static boolean writeUpgradeLogFile(String content) { | ||
| UpgradeUtils.getUpgradeLogLock().writeLock().lock(); | ||
| try (BufferedWriter upgradeLogWriter = new BufferedWriter( |
Contributor
There was a problem hiding this comment.
I think it is not necessary to open a writer every time, you can reuse one.
fanhualta
requested changes
Nov 7, 2019
| tsfilePathBefore + DOT_SEPERATOR + tsfilePathAfter + DOT_SEPERATOR | ||
| + UpgradeCheckStatus.AFTER_UPGRADE_FILE, upgradePostion); | ||
| } catch (IOException e) { | ||
| logger.error("generate upgrade file failed, the file to be upgraded:{}", tsfilePathBefore); |
Contributor
There was a problem hiding this comment.
When it occurs in the running of the system, the system engine may read this file which lead to errors.
jt2594838
approved these changes
Nov 7, 2019
fanhualta
approved these changes
Nov 8, 2019
qiaojialin
requested changes
Nov 10, 2019
Contributor
Author
However, it still has some conflict with merge as you have said. I will discuss with jt to solve the problem. |
qiaojialin
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.