Skip to content

Comments

[IOTDB-467] The CLI displays query results in a batch manner#806

Merged
qiaojialin merged 3 commits intoapache:masterfrom
dynamicDr:master
Feb 15, 2020
Merged

[IOTDB-467] The CLI displays query results in a batch manner#806
qiaojialin merged 3 commits intoapache:masterfrom
dynamicDr:master

Conversation

@dynamicDr
Copy link
Contributor

No description provided.

@Genius-pig
Copy link
Contributor

Thank you for your contribution. But it has been done by #804

@liutaohua
Copy link
Contributor

Thank you for your contribution. But it has been done by #804

welcome for new contributor ,#804 was closed

Copy link
Member

@qiaojialin qiaojialin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution! The code is clean and the CLI has a good user experience.

Three suggestions:

(1) if you use the IDEA and mac, please import the java-google-style.xml and option+command+L to format the code.
(2) Fortunately, the other PR for the same issue is closed by the author :) In order not to do duplicated work, it's better to leave a comment on the Jira to claim that you will solve the issue.
(3) We have a weixin group to communicate, you could join through my weixin: qiaojialin1993

@dynamicDr dynamicDr requested a review from qiaojialin February 15, 2020 04:23
Co-Authored-By: Jialin Qiao <qjl16@mails.tsinghua.edu.cn>
Copy link
Member

@qiaojialin qiaojialin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix compilation error

@dynamicDr
Copy link
Contributor Author

Hi, thanks for your contribution! The code is clean and the CLI has a good user experience.

Three suggestions:

(1) if you use the IDEA and mac, please import the java-google-style.xml and option+command+L to format the code.
(2) Fortunately, the other PR for the same issue is closed by the author :) In order not to do duplicated work, it's better to leave a comment on the Jira to claim that you will solve the issue.
(3) We have a weixin group to communicate, you could join through my weixin: qiaojialin1993

Thanks for your advice!
I've made some changes on it.

@qiaojialin qiaojialin merged commit 866eb70 into apache:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants