Skip to content

update license #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qiaojialin merged 21 commits into from
Mar 15, 2019
Merged

update license #94

qiaojialin merged 21 commits into from
Mar 15, 2019

Conversation

@qiaojialin
Copy link
Member

@qiaojialin qiaojialin commented Mar 12, 2019 •
edited
Loading

Jira issue:

https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-45?filter=allopenissues

Replace org.json with alibaba.fastjson
Remove netty dependency
Update license and notice file
Add license in Licenses/

@MyXOF
Copy link
Member

MyXOF commented Mar 12, 2019

You should send an email to our community to check whether you can add hive apache license to our project

jixuan1989
jixuan1989 reviewed Mar 13, 2019
View reviewed changes
example/rocketmq/pom.xml Outdated
<artifactId>netty-buffer</artifactId>
</exclusion>
</exclusions>
<version>0.8.0-SNAPSHOT</version>
Copy link
Member

@jixuan1989 jixuan1989 Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems <version> is not needed because the root pom is iotdb

Copy link
Member

@MyXOF MyXOF Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use <version>${project.version}</version> ?

Copy link
Member

@jixuan1989 jixuan1989 Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can omit the declaration in this case..

Copy link
Member Author

@qiaojialin qiaojialin Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

jixuan1989
jixuan1989 requested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@jixuan1989 jixuan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGPL 2.1 seems not be used.

@jixuan1989
Copy link
Member

jixuan1989 commented Mar 13, 2019

LGPL 2.1 seems not be used.

And pls make sure that EDL license file is included.

jt2594838
jt2594838 requested changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@jt2594838 jt2594838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several InputStreams in tests seem left unclosed.

@qiaojialin
Copy link
Member Author

qiaojialin commented Mar 14, 2019

LGPL 2.1 seems not be used.

removed

@qiaojialin
Copy link
Member Author

qiaojialin commented Mar 14, 2019

LGPL 2.1 seems not be used.

And pls make sure that EDL license file is included.

@jixuan1989 added

@qiaojialin
Copy link
Member Author

qiaojialin commented Mar 14, 2019

Several InputStreams in tests seem left unclosed.

I have put inputstream into a try()

@qiaojialin qiaojialin merged commit 7a563c0 into master Mar 15, 2019
@qiaojialin qiaojialin deleted the update_license branch March 15, 2019 11:28
mychaow added a commit that referenced this pull request Dec 13, 2021
@mychaow
Merge pull request #94 from bonc-cloud/fix_register_schema_failed
0528fed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MyXOF MyXOF MyXOF left review comments

@jixuan1989 jixuan1989 jixuan1989 approved these changes

@jt2594838 jt2594838 jt2594838 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiaojialin @MyXOF @jixuan1989 @jt2594838