Bugfix/knn validation #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should remove the hardcoded schema names from the tests as well. If MADlib is installed in a different schema, they might create problems. |
Contributor
|
|
- Some input validation was missing which is included now. - there was still a bug wrt ambiguious references to column names, which was only partly handled previously. - In this version, the classification label column must be an integer, 1 and 0 for true and false. Having a boolen is not working out well since madlib's mode function does not work with booleans. This issue remains to be fixed, most likely will be fixed after 1.10.0
Remove redundant validation from sql, and remove madlib schema name from install check.
njayaram2
force-pushed
the
bugfix/knn-validation
branch
from
a060ed7 to
7477b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knn: Fix input validation issues
which was only partly handled previously.