This repository was archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Improved test for BilinearSampler #12427
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
New test passed more than 10000 trials on CPU, GPU and CuDNN on both req types: |
904d736 to
d826dd6
Compare
samskalicky
reviewed
Aug 31, 2018
d826dd6 to
c85da80
Compare
samskalicky
approved these changes
Aug 31, 2018
Contributor
samskalicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Author
|
@marcoabreu @larroy @lebeg Can you guys take a look when you have time? Should be good for merge. |
lebeg
reviewed
Sep 3, 2018
lebeg
approved these changes
Sep 5, 2018
Contributor
Author
|
@anirudh2290 @sandeep-krishnamurthy @nswamy Should be ready for merge. |
anirudh2290
reviewed
Sep 5, 2018
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Sep 11, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #12248.
Checklist
Essentials
Changes
Comments
CPU, GPU and CuDNN versions all failed on the same seed with the same "wrong" number, which means our 2 versions are consistent with the CuDNN version, so the reference answer calculated by the original helper function within the unit test should be problem here. Changing the test from comparing to the reference answer to a consistency check where the 3 versions are compared against each other to check for correctness.