This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[WIP] loosen numpy version requirement#17200
Merged
leezu merged 1 commit intoapache:masterfrom Jan 2, 2020
Merged
Conversation
Contributor
Author
leezu
approved these changes
Jan 2, 2020
Contributor
|
Wasn't numpy version restriction (<1.18) done to prevent numpy.decorator issue? @leezu @reminisce |
Contributor
|
It was also done due to #17154 That issue was fixed and no other failing tests found. Thus @reminisce loosened the requirement. Could you link the issue that tracks the remaining problems? |
Contributor
|
Any idea which PR should be merged to get 1.5.x into working? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments