[NETBEANS-2121] Updated dependency version on our Java EE support modules.#1140
Merged
lkishalmi merged 1 commit intoapache:masterfrom Feb 19, 2019
Merged
[NETBEANS-2121] Updated dependency version on our Java EE support modules.#1140lkishalmi merged 1 commit intoapache:masterfrom
lkishalmi merged 1 commit intoapache:masterfrom
Conversation
JaroslavTulach
approved these changes
Feb 19, 2019
JaroslavTulach
left a comment
JaroslavTulach
left a comment
There was a problem hiding this comment.
It is not easy to check whether the dependencies are correct just by looking at the diff, but yes, this would be the fix.
|
How can I test the result - should I install the build from here https://builds.apache.org/job/incubator-netbeans-linux/ ? |
Member
|
Yes, once it has been merged, wait for the next build, and then try it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module we are depending on is org.netbeans.modules.j2ee.persistenceapi has a version 1.40.0 it has the include implementation version checkbox ticked in and its implementation version is 1.
Shall I mark the dependency as 1.40.0.1 instead?
Telling the truth I could not reproduce the CNFE locally, but I just have one project where I can test this an it works there.
The other part of the commit is just Maven -> Gradle renames.