Skip to content

Backport of dbalek's fixes made after Apr 22, 2017#274

Merged
geertjanw merged 45 commits intoapache:masterfrom
dbalek:dbalek/after_donation
Nov 14, 2017
Merged

Backport of dbalek's fixes made after Apr 22, 2017#274
geertjanw merged 45 commits intoapache:masterfrom
dbalek:dbalek/after_donation

Conversation

@dbalek
Copy link
Copy Markdown
Contributor

@dbalek dbalek commented Nov 14, 2017

This is a batch commit of changes for NetBeans 9 done during legal review of sources already being reviewed and donated. These changes were not part of original donation and contain important fixes for Apache NetBeans to work on/with JDK9.

…java.source.save.Reindenter$$Lambda$227/34841035 to javax.tools.DiagnosticListener - fixed.
…m carriage returns across the editor - fixed.
…m intermittently - Initialize the module system model even in presence of missing/broken module-infos; BadClassFiles should not immediatelly abort compilation anymore, but should be handled as if the classfile did not exist.
…pletion.JavaCompletionTask.addLocalMembersAndVars - fixed.
dbalek and others added 15 commits November 13, 2017 14:39
…type$iterator,org.clank.support.aliases.type$iterator,org.clank.java.std.Compare)void - fixed.
…a.ui.WatchPanel$MyTrees cannot be cast to com.sun.source.util.DocTrees - fixed.
…arser$SimpleEndPosTable cannot be cast to org.netbeans.lib.nbjavac.services.NBParserFactory$NBJavacParser$EndPosTableImpl - fixed.
@bdelacretaz
Copy link
Copy Markdown
Member

Are you the author of all these changes? The "Backport of dbalek's changes" title seems to imply that you are, but if not the authors need to be identified.

@geertjanw
Copy link
Copy Markdown
Member

Yes, he's the author.

@dbalek
Copy link
Copy Markdown
Contributor Author

dbalek commented Nov 14, 2017

Why do you think the changes are not mine?

@geertjanw
Copy link
Copy Markdown
Member

Because there's so many. It's a compliment. :-)

@dbalek
Copy link
Copy Markdown
Contributor Author

dbalek commented Nov 14, 2017

That is cumulative work since April till now :-)

@bdelacretaz
Copy link
Copy Markdown
Member

Cool! I did not imply the changes are not yours, just verifying that they are as it's important in an Apache context. With my incubation mentor hat on...we're all good, thanks for clarifying.

@geertjanw
Copy link
Copy Markdown
Member

OK, looked through them, makes sense to me, merging.

@geertjanw geertjanw merged commit 5d0b08c into apache:master Nov 14, 2017
@dbalek dbalek deleted the dbalek/after_donation branch November 14, 2017 14:42
Achal1607 added a commit to Achal1607/netbeans that referenced this pull request Feb 21, 2025
JDK 23 download option added in JDK Downloader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants