Fixing org.netbeans.modules.openide.awt.ActionProcessorTest - ensurin…#347
Merged
geertjanw merged 1 commit intoapache:masterfrom Dec 31, 2017
Merged
Conversation
…rTest - ensuring nb-javac-api is used for modules that have requires.nb.javac=true, but removing that flag from openide.awt, as that shouldn't need that.
jlahoda
force-pushed
the
fix-openide-awt-tests
branch
from
4f6a8e4 to
ad6c813
Compare
Member
|
Thanks, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g nb-javac-api is used for modules that have requires.nb.javac=true, but removing that flag from openide.awt, as that shouldn't need that.
(Recently, requires.nb.javac=true was changed to always use unmodified vanilla javac API. While that is conceptually good, the vanilla javac API does not seem to be able to load javac on JDK 8.)