Skip to content

Backport of junichi11's fixes made after Apr 22, 2017#607

Merged
geertjanw merged 15 commits intoapache:2ndDonationfrom
junichi11:after_donation_junichi11
Jun 27, 2018
Merged

Backport of junichi11's fixes made after Apr 22, 2017#607
geertjanw merged 15 commits intoapache:2ndDonationfrom
junichi11:after_donation_junichi11

Conversation

@junichi11
Copy link
Member

@junichi11 junichi11 commented Jun 26, 2018

junichi11 added 15 commits June 27, 2018 02:09
@junichi11
#262141 - [PHP7] Context sensitive lexer & Uniform variable syntax
de726e0 
Context sensitive lexer part
@junichi11
Fix a warning
aeefe15 
Don't add <b></b> twice.
WARNING [org.netbeans.modules.editor.completion.PatchedHtmlRenderer]: Closing bold tag w/o opening bold tag
WARNING [org.netbeans.modules.editor.completion.PatchedHtmlRenderer]:   <font color=#00003C><b><b>$GLOBALS</b></b></font>
WARNING [org.netbeans.modules.editor.completion.PatchedHtmlRenderer]:                                          ^
WARNING [org.netbeans.modules.editor.completion.PatchedHtmlRenderer]:  Full HTML string:<font color=#00003C><b><b>$GLOBALS</b></b></font>
@junichi11
#262141 - [PHP7] Context sensitive lexer & Uniform variable syntax
0447955 
Uniform variable syntax part. Some features(CC, GotoDeclaration, MarkOccurrences) don't work with (...) expression yet.
@junichi11
#268497 - Keyword "instanceof" is not colored correctly in 8.2
61e3742
@junichi11
#249508 - In a function, foreach with list($a) warns about uninitiali…
3d6cb8f 
…zed $a
@junichi11
#256759 - @Property ignores all but the last type when multiple types…
efca55a 
… are declared with pipe (|) during auto-complete
@junichi11
#270733 - Constructors for user defined Exception are not shown in a …
7b3bb99 
…CC list
@junichi11
#268541 - If else formating
424fb79
@junichi11
#269903 - NullPointerException at org.netbeans.modules.php.smarty.edi…
fb23f0d 
…tor.parser.TplParser.parse
@junichi11
#270903 - Wrong formatting for method/function parameters when the wr…
7c7e405 
…apping always option is set
@junichi11
#243203 - Nested calls broken since 7.2
f69eb9c
@junichi11
#270987 - Code Analysis not working with current Version of phpcs and…
c238b6c 
… php-cs-fixer
@junichi11
#271062 - AssertionError: WHITESPACE
89a7433
@junichi11
#271109 - Bogus syntax error on ((string)$this->foo)[0]
8a89650 
Also, fix missing unhandled errors(e.g. foo()(), foo->bar()(), Foo::bar()()).
@junichi11
#271040 - Twig syntax error with {% endset %}
4ec624d
@geertjanw
Copy link
Member

geertjanw commented Jun 27, 2018

Very cool. Should we wait to relicense everything in the 2nd donation or integrate this there already?

@junichi11
Copy link
Member Author

junichi11 commented Jun 27, 2018 •
edited
Loading

I'm not sure but some people (e.g. @JaroslavTulach, @sdedic, @dbalek ) did the same thing in the 1st donation.
Furthermore, I have 8 patches for new features. When I worked on them, I didn't push them because new feature phase was already past. So I just attached them to each issue. e.g.

I would like to merge them as soon as possible because I'm not sure whether I can apply patches correctly after license headers are changed.

If there is a problem, I'll just wait :)
Thanks!

@geertjanw
Copy link
Member

geertjanw commented Jun 27, 2018

Are there any that need to be reviewed or should we merge them all without additional steps? Up to you, either way, happy to do what you think best.

@junichi11
Copy link
Member Author

junichi11 commented Jun 27, 2018

I suppose we need not review them. I hope that they are merged if anyone else has no objection. I'll wait a while.

@geertjanw
Copy link
Member

geertjanw commented Jun 27, 2018

OK, merging.

@geertjanw geertjanw merged commit 918cddf into apache:2ndDonation Jun 27, 2018
@junichi11
Copy link
Member Author

junichi11 commented Jun 27, 2018 •
edited
Loading

Probably, in this case, we should not squash & merge because it would be big one commit and it would be hard to find specified changes...

junichi11 added a commit that referenced this pull request Jun 28, 2018
@junichi11
Revert "Backport of junichi11's fixes made after Apr 22, 2017 (#607)"
df53a14 
This reverts commit 918cddf.
@junichi11 junichi11 mentioned this pull request Jun 28, 2018
Merged
@junichi11 junichi11 deleted the after_donation_junichi11 branch June 28, 2018 12:41
@junichi11 junichi11 mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junichi11 @geertjanw