[NETBEANS-406] Fix a potential memory leak involving DocumentUtilitie… #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This changeset is based on discussion in PR #515 - the comments there might help with review. As I suggested the fix, I decided to finally take it on and get it done. |
Contributor
|
Brilliant--thank you! |
sdedic
approved these changes
Sep 7, 2018
| is.autoload=true | ||
| javac.source=1.7 | ||
| javac.compilerargs=-Xlint:unchecked | ||
| spec.version.base=2.20.0 |
Member
There was a problem hiding this comment.
Please increment minor version; micro one is incremented for branched release patches AFAIK.
Contributor
Author
There was a problem hiding this comment.
Ok. I updated the commit accordingly. I'll wait for travis to do its job and push tonight, thanks for checking.
…s.addPropertyChangeListener. WeakListeners.propertyChange(lister, source) expected, that it can detach from the supplied source by invoking removePropertyChangeListener on it. This contract is violated in this construct: DocumentUtilities.addPropertyChangeListener(doc, WeakListeners.propertyChange(this, doc)); DocumentUtilities does not attach the PropertyChangeListener to the document, but to a PropertyChangeLister contained in it. The Document itself does not support removePropertyChangeListener. The solution is to add a new api method addWeakPropertyChangeListener, that hides the complexity from the user. The issue was raised and diagnosed by Eirik Bakke.
matthiasblaesing
force-pushed
the
netbeans-406
branch
from
b53d19e to
5058fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s.addPropertyChangeListener.
WeakListeners.propertyChange(lister, source) expected, that it can
detach from the supplied source by invoking removePropertyChangeListener
on it. This contract is violated in this construct:
DocumentUtilities.addPropertyChangeListener(doc, WeakListeners.propertyChange(this, doc));
DocumentUtilities does not attach the PropertyChangeListener to the
document, but to a PropertyChangeLister contained in it. The Document
itself does not support removePropertyChangeListener.
The solution is to add a new api method addWeakPropertyChangeListener,
that hides the complexity from the user.
The issue was raised and diagnosed by Eirik Bakke.
Closes: #515