-
Notifications
You must be signed in to change notification settings - Fork 647
build: Use flock to serialize ar steps as workaround #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use flock to serialize ar steps to avoid parallel build break sometimes. Change-Id: I3a916b3b27422cdb6d718f7d554361565457fa08 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
|
A general version of: |
|
@masayuki2009 please associate your github account with apache account: |
@xiaoxiang781216 I'll setup it later. |
|
@xiaoxiang781216 I've just added my github account info to the apache. |
|
macOS doesn't have flock. |
But shlock doesn't exist on cygwin and msys2, even Ubuntu need install manually with apt-get install:(. |
|
How about https://github.com/discoteq/flock: |
|
@xiaoxiang781216 It looks good to me. |
This would need to be documented so macOS users would have to install flock? I will merge this PR when the documentation updates are in place. This should be covered in the top-level README.txt file. |
|
@patacongo here is the patch updating README.txt: |
|
Hi, @xiaoxiang781216, I found that this solution still has a problem. I think the lock file should be in the same directory as '.a' file, Or as I tried before, the lock file could be at the top directory. (rather giant lock) |
Yes, I will send a new PR fix this issue. |
|
@masayuki2009 see this: |
Use flock to serialize ar steps to avoid parallel build break
sometimes.
Change-Id: I3a916b3b27422cdb6d718f7d554361565457fa08
Signed-off-by: Xiang Xiao xiaoxiang@xiaomi.com