netutils/netcat: fixed ISO C89/C90 related warnings#972
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Jan 21, 2022
Merged
netutils/netcat: fixed ISO C89/C90 related warnings#972xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
warning: ISO C90 forbids variable length array ‘buf’ [-Wvla] warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
xiaoxiang781216
approved these changes
Jan 21, 2022
|
|
||
| while (true) | ||
| { | ||
| ssize_t avail = read(infd, buf, capacity); |
Contributor
There was a problem hiding this comment.
Actually this is not a C89 issue. Standard allows this.
Contributor
Author
There was a problem hiding this comment.
Yes, "ssize_t avail" was moved not because of C89. I moved it together with moving "ssize_t written" that was C89 related issue. So I moved "ssize_t avail" for uniformity reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the following types of warnings:
warning: ISO C90 forbids variable length array ‘buf’ [-Wvla]
warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
Impact
netutils/netcat
Testing