Skip to content

Conversation

@yamt
Copy link
Contributor

@yamt yamt commented Feb 25, 2020

No description provided.

all: $(BIN)
.PHONY: dirlinks context clean_context check_context configenv config oldconfig menuconfig nconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean
.PHONY: pass1 pass1deps pass1dep
.PHONY: pass2 pass2deps pass2dep
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge into one line since line 180 is already very long.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for jumping in but isn't that hardly readable
I propose that we split in on several lines

@patacongo
Copy link
Contributor

@xiaoxiang781216 Please merge if and when you are satisfied with the change.

@xiaoxiang781216 xiaoxiang781216 merged commit aa40e28 into apache:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants