Skip to content

Add the base source code for Ruby 2.5 Runtime#1

Merged
rabbah merged 19 commits intoapache:masterfrom
remore:master
Jul 23, 2018
Merged

Add the base source code for Ruby 2.5 Runtime#1
rabbah merged 19 commits intoapache:masterfrom
remore:master

Conversation

@remore
Copy link
Contributor

@remore remore commented Jul 17, 2018

@jthomas jthomas requested a review from rabbah July 17, 2018 19:05
README.md Outdated
-->

# Apache OpenWhisk runtimes for Ruby
[![Build Status](https://travis-ci.org/remore/openwhisk-runtime-ruby.svg?branch=master)](https://travis-ci.org/remore/openwhisk-runtime-ruby)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with 73c0cb7


Or you can use `wskdev` and create a soft link to the target ansible environment, for example:
```
ln -s ${ROOTDIR}/ansible/environments/local ${OPENWHISK_HOME}/ansible/environments/local-ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the manifest change is made upstream i dont think you need this special environment here and we can simplify here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Which one is corresponding PR for this?

README.md Outdated
Or save in your `$HOME/.gradle/gradle.properties`
```
systemProp.http.proxyHost=localhost
systemProp.http.proxyPort=3128
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm why did you need to use a proxy? this isn't generally needed even for mac anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah those are just coming from other runtime documentation such as nodejs or php. Maybe better to remove these proxy-related documentations unless I have examined it's working?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t be needed here or in other runtimes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rabbah Understood. Updated with e009e18

override val testLargeInput = {
TestConfig("""
|def main(args)
| puts 'hello stdout'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont think test cares about stdout/stderr here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Fixed this with 73c0cb7

@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need this file.

@rabbah rabbah merged commit 0189b81 into apache:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants