Make logging hot paths lighter.#2784
Merged
Merged
Conversation
markusthoemmes
added
the
review
markusthoemmes
force-pushed
the
lighter-log
branch
from
087f0ad to
0d054c8
Compare
Logging is **the** hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation. It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.
markusthoemmes
force-pushed
the
lighter-log
branch
from
0d054c8 to
6a2fa66
Compare
Contributor
Author
|
PG1 2087 🔵 |
Member
|
With these prs can we record pre and post improvements? |
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Sep 22, 2017
Logging is **the** hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation. It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
Logging is **the** hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation. It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
Logging is **the** hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation. It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 14, 2017
Logging is **the** hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation. It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
Logging is **the** hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation. It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging is the hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation.
It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.