[common] Load plugin classes directly from jar without decompression#1996
Merged
JingsongLi merged 2 commits intoapache:masterfrom Sep 15, 2023
tsreaper:directory-class-loader
Merged
[common] Load plugin classes directly from jar without decompression#1996JingsongLi merged 2 commits intoapache:masterfrom tsreaper:directory-class-loader
JingsongLi merged 2 commits intoapache:masterfrom
tsreaper:directory-class-loader
Conversation
tsreaper
changed the title
Contributor
|
This solution can not work in JDK 11 and JDK 17. |
Contributor
Author
Changed the solution a bit and now it works on both JDK 11 and 17. |
schnappi17
pushed a commit
to schnappi17/flink-table-store
that referenced
this pull request
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently to load classes from plugins,
PluginLoaderhave to decompress a jar file out of Paimon distribution jar and load that jar file. It is hard for a long existing client (for example a SQL gateway service) to clean up these jar files.This PR fixes the issue by loading plugin classes directly from distribution jar without decompression.
Tests
Existing tests should cover the change.
API and Format
No.
Documentation
No.