Skip to content

Conversation

@apucher
Copy link
Contributor

@apucher apucher commented Jan 14, 2019

this is a half-solution to ignore single-character directories - including the "?" directory

@apucher
Copy link
Contributor Author

apucher commented Jan 14, 2019

@Jackie-Jiang

@codecov-io
Copy link

Codecov Report

Merging #3687 into master will increase coverage by 9.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3687      +/-   ##
============================================
+ Coverage     57.32%   67.29%   +9.97%     
  Complexity        4        4              
============================================
  Files          1027     1027              
  Lines         50863    50863              
  Branches       7106     7106              
============================================
+ Hits          29155    34227    +5072     
+ Misses        19557    14301    -5256     
- Partials       2151     2335     +184
Impacted Files Coverage Δ Complexity Δ
...lix/EmptyBrokerOnlineOfflineStateModelFactory.java 86.66% <0%> (-13.34%) 0% <0%> (ø)
...va/org/apache/pinot/common/data/TimeFieldSpec.java 91.35% <0%> (ø) 0% <0%> (ø) ⬇️
...ator/transform/function/BaseTransformFunction.java 29.95% <0%> (+0.42%) 0% <0%> (ø) ⬇️
...g/apache/pinot/common/utils/helix/HelixHelper.java 54.16% <0%> (+0.59%) 0% <0%> (ø) ⬇️
.../pinot/core/segment/index/SegmentMetadataImpl.java 82.63% <0%> (+0.69%) 0% <0%> (ø) ⬇️
...ment/creator/impl/SegmentColumnarIndexCreator.java 88.41% <0%> (+0.77%) 0% <0%> (ø) ⬇️
...r/transform/function/ValueInTransformFunction.java 39.2% <0%> (+0.8%) 0% <0%> (ø) ⬇️
...a/org/apache/pinot/common/utils/ServiceStatus.java 70.73% <0%> (+0.81%) 0% <0%> (ø) ⬇️
...e/io/writer/impl/MutableOffHeapByteArrayStore.java 86.45% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...org/apache/pinot/controller/ControllerStarter.java 61.95% <0%> (+1.08%) 0% <0%> (ø) ⬇️
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42af32...ec1fa1d. Read the comment docs.

@apucher apucher closed this Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants