[TE] frontend - harleyjj/share-dashboard - extend anomalies by subscr…#4132
Merged
jihaozh merged 1 commit intoapache:masterfrom Apr 18, 2019
Merged
[TE] frontend - harleyjj/share-dashboard - extend anomalies by subscr…#4132jihaozh merged 1 commit intoapache:masterfrom
jihaozh merged 1 commit intoapache:masterfrom
Conversation
…iption group to share-dashboard
jihaozh
reviewed
Apr 18, 2019
| } else if (this.get('appName')) { | ||
| anomalies = yield this.get('anomaliesApiService').queryAnomaliesByAppName(this.get('appName'), this.get('startDate'), this.get('endDate')); | ||
| } else { | ||
| anomalies = yield this.get('anomaliesApiService').queryAnomaliesBySubGroup(this.get('subGroup'), this.get('startDate'), this.get('endDate')); |
Member
There was a problem hiding this comment.
Which endpoint is this calling? So that I can double check the backend to see if it's correct.
Contributor
Author
There was a problem hiding this comment.
Here's an example, with appName and group seeming to have join behavior, based on the responses I've gotten:
/userdashboard/anomalies?appName={someAppName}group={someSubGroup}
Member
There was a problem hiding this comment.
Right. Doubled check this will work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iption group to share-dashboard
The user can share anomalies in an email, link, or pdf grouped by subscription group, as an alternative to the present sharing functionality of anomalies by application.