Skip to content

Comments

Fixing StartZooKeeper Command#5295

Merged
xiangfu0 merged 1 commit intomasterfrom
bugfixing-auto-delete-zk-dir
Apr 25, 2020
Merged

Fixing StartZooKeeper Command#5295
xiangfu0 merged 1 commit intomasterfrom
bugfixing-auto-delete-zk-dir

Conversation

@xiangfu0
Copy link
Contributor

  1. Allow user to customize zk data dir
  2. Don't delete zk data dir after process shutdown. (Default zk data dir is under java tmp, which will be auto recycled)

@xiangfu0 xiangfu0 force-pushed the bugfixing-auto-delete-zk-dir branch from 843cd60 to 994cb88 Compare April 25, 2020 00:43
@codecov-io
Copy link

Codecov Report

Merging #5295 into master will decrease coverage by 9.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5295      +/-   ##
==========================================
- Coverage   66.09%   56.95%   -9.15%     
==========================================
  Files        1067     1070       +3     
  Lines       54543    54598      +55     
  Branches     8130     8134       +4     
==========================================
- Hits        36050    31094    -4956     
- Misses      15848    21075    +5227     
+ Partials     2645     2429     -216     
Impacted Files Coverage Δ
...a/org/apache/pinot/minion/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/minion/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/core/query/reduce/ComparisonFunction.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...ot/minion/events/EventObserverFactoryRegistry.java 0.00% <0.00%> (-100.00%) ⬇️
...t/minion/executor/TaskExecutorFactoryRegistry.java 0.00% <0.00%> (-100.00%) ⬇️
...minion/executor/ConvertToRawIndexTaskExecutor.java 0.00% <0.00%> (-100.00%) ⬇️
...nion/events/DefaultMinionEventObserverFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...startree/executor/StarTreeAggregationExecutor.java 0.00% <0.00%> (-100.00%) ⬇️
... and 317 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd2110...994cb88. Read the comment docs.

@xiangfu0 xiangfu0 merged commit f566932 into master Apr 25, 2020
@xiangfu0 xiangfu0 deleted the bugfixing-auto-delete-zk-dir branch April 25, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants