Merged
Conversation
Contributor
xiangfu0
commented
Apr 24, 2020
- Allow user to customize zk data dir
- Don't delete zk data dir after process shutdown. (Default zk data dir is under java tmp, which will be auto recycled)
kishoreg
approved these changes
Apr 24, 2020
843cd60 to
994cb88
Compare
Codecov Report
@@ Coverage Diff @@
## master #5295 +/- ##
==========================================
- Coverage 66.09% 56.95% -9.15%
==========================================
Files 1067 1070 +3
Lines 54543 54598 +55
Branches 8130 8134 +4
==========================================
- Hits 36050 31094 -4956
- Misses 15848 21075 +5227
+ Partials 2645 2429 -216
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.