RYA-253 Converted the rya.prospector class from Groovy to Java. Also added documentation to the project. by kchilton2 · Pull Request #151 · apache/rya

kchilton2 · 2017-04-10T19:11:54Z

No description provided.

isper3at · 2017-04-10T20:45:42Z

-                } catch (AccumuloSecurityException e) {
-                    e.printStackTrace();
+                } catch (final AccumuloException | AccumuloSecurityException | TableExistsException e) {
+                    LOG.warn("A problem was encountered while setting the Configuration for the EntityOptimizer.", e);


there a way we can make this more informative?

I don't know what else you'd say here. The chained exception will have the details.

isper3at · 2017-04-10T20:45:49Z

-            } catch (AccumuloSecurityException e) {
-                e.printStackTrace();
+            } catch (final AccumuloException | AccumuloSecurityException | TableExistsException e) {
+                LOG.warn("A problem was encountered while constructing the EntityOptimizer.", e);


there a way we can make this more informative?

I don't know what else you'd say here. The chained exception will have the details.

isper3at · 2017-04-10T20:46:10Z

 import com.google.common.base.Joiner;

-public class EntityTupleSet extends ExternalSet implements ExternalBatchingIterator {
+/*


move the license to the top

isper3at · 2017-04-10T20:46:44Z

+                minCard = csp.getCardinality();
+                minSp = csp.getSp();
+            } else {
+                // TODO come up with a better default if cardinality is not


is this a 'make jira ticket' todo or can this be removed?

I have no idea. This comment was already present when I was converting.

isper3at · 2017-04-10T20:54:41Z

+    }
+
+    @Override
+    public int compareTo(IntermediateProspect t) {


is this the norm for this kind of comparison? seems odd.

Not sure. This is how it was already working so I'm not changing it.

isper3at · 2017-04-10T20:55:12Z

+     * The data portion of an {@link IndexEntry} contains a unique Subject that
+     * appears within a Rya instance's Statements.
+     */
+    subject,


don't conventions put enums as all capitalized?

Yea, I'll update the code.

Just kidding, that breaks things because it uses the enum's value as part of the Row Key in accumulo. I don't want to change the functionality, so I'm leaving it.

can't you override getValue() to return the lowercase?

There is no getValue() method on enums. It's using toString() and valueOf(String). I would have to implement new methods on the enum to handle this case. Which I can do if this style is a deal breaker.

I personally would like the extra functionality to keep to the convention

isper3at · 2017-04-10T21:16:15Z

+        assert outTable != null;
+        assert auths_str != null;
+
+        final Job job = new Job(getConf(), this.getClass().getSimpleName() + "_" + System.currentTimeMillis());


I'm not changing the behavior of the code, I'm just converting it from Groovy to Java, so I'm going to leave this as is.

then I don't think NOW is ever used

It is used on lines 67 and 85.

isper3at · 2017-04-10T21:54:57Z

-    void setKey(K key) {
-        this.key = key
+    public void setKey(K key) {
+        this.key = key;


how was this even working without semicolons before.....

It was groovy.

kchilton2 · 2017-04-11T00:05:29Z

Update to reflect Andrew's comments.

kchilton2 · 2017-04-11T01:29:59Z

Changing the enums to all makes the unit tests fail because those enum values as strings are used within the storage, so I'm going to back out that change in my next update to this PR.

isper3at · 2017-04-11T16:57:17Z

kchilton2 · 2017-04-11T17:06:42Z

asfbot build

kchilton2 · 2017-04-11T17:16:56Z

asfbot build

meiercaleb · 2017-04-11T17:18:06Z

asfbot build

asfbot · 2017-04-11T18:10:54Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/44/

Build result: FAILURE

[...truncated 6.62 MB...][INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[JENKINS] Archiving disabled[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 47:57 min[INFO] Finished at: 2017-04-11T18:08:47+00:00[INFO] Final Memory: 189M/996M[INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal on project rya.geoindexing: Could not resolve dependencies for project org.apache.rya:rya.geoindexing:jar:3.2.11-incubating-SNAPSHOT: The following artifacts could not be resolved: mil.nga.giat:geowave-datastore-accumulo:jar:0.9.3, mil.nga.giat:geowave-adapter-vector:jar:0.9.3: Could not find artifact mil.nga.giat:geowave-datastore-accumulo:jar:0.9.3 in osgeo (http://download.osgeo.org/webdav/geotools/) -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.geoindexingchannel stoppedSetting status of a6c904c to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/44/ and message: 'Build finished. 'Using context: asfbot build

kchilton2 · 2017-04-11T18:14:58Z

asfbot build

asfbot · 2017-04-11T18:42:45Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/45/

Build result: FAILURE

[...truncated 5.84 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 27:41 min[INFO] Finished at: 2017-04-11T18:39:11+00:00[INFO] Final Memory: 250M/1144M[INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal on project rya.geoindexing: Could not resolve dependencies for project org.apache.rya:rya.geoindexing:jar:3.2.11-incubating-SNAPSHOT: The following artifacts could not be resolved: mil.nga.giat:geowave-datastore-accumulo:jar:0.9.3, mil.nga.giat:geowave-adapter-vector:jar:0.9.3: Failure to find mil.nga.giat:geowave-datastore-accumulo:jar:0.9.3 in http://download.osgeo.org/webdav/geotools/ was cached in the local repository, resolution will not be reattempted until the update interval of osgeo has elapsed or updates are forced -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.geoindexingchannel stoppedSetting status of a6c904c to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/45/ and message: 'Build finished. 'Using context: asfbot build

asfbot · 2017-04-11T19:15:41Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/46/

Build result: FAILURE

[...truncated 5.83 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 28:02 min[INFO] Finished at: 2017-04-11T19:11:33+00:00[INFO] Final Memory: 242M/987M[INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal on project rya.geoindexing: Could not resolve dependencies for project org.apache.rya:rya.geoindexing:jar:3.2.11-incubating-SNAPSHOT: The following artifacts could not be resolved: mil.nga.giat:geowave-datastore-accumulo:jar:0.9.3, mil.nga.giat:geowave-adapter-vector:jar:0.9.3: Failure to find mil.nga.giat:geowave-datastore-accumulo:jar:0.9.3 in http://download.osgeo.org/webdav/geotools/ was cached in the local repository, resolution will not be reattempted until the update interval of osgeo has elapsed or updates are forced -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.geoindexingchannel stoppedSetting status of a6c904c to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/46/ and message: 'Build finished. 'Using context: asfbot build

amihalik · 2017-04-12T20:21:46Z

asfbot build

…added documentation to the project.

asfbot · 2017-04-12T21:37:35Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests-on-demand/47/

Build result: ABORTED

isper3at reviewed Apr 10, 2017

View reviewed changes

kchilton2 force-pushed the RYA-253 branch from b339777 to bd85eda Compare April 11, 2017 00:05

kchilton2 force-pushed the RYA-253 branch from bd85eda to 21d57a6 Compare April 11, 2017 04:19

amihalik approved these changes Apr 11, 2017

View reviewed changes

isper3at approved these changes Apr 11, 2017

View reviewed changes

kchilton2 force-pushed the RYA-253 branch from a6c904c to 79e60a9 Compare April 12, 2017 20:27

RYA-253 Converted the rya.prospector class from Groovy to Java. Also …

b041143

…added documentation to the project.

kchilton2 force-pushed the RYA-253 branch from 79e60a9 to b041143 Compare April 12, 2017 21:25

asfgit closed this in bd9b912 Apr 13, 2017

kchilton2 deleted the RYA-253 branch April 14, 2017 01:33

Conversation

kchilton2 commented Apr 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kchilton2 commented Apr 11, 2017

Uh oh!

kchilton2 commented Apr 11, 2017

Uh oh!

isper3at commented Apr 11, 2017

Uh oh!

kchilton2 commented Apr 11, 2017

Uh oh!

kchilton2 commented Apr 11, 2017

Uh oh!

meiercaleb commented Apr 11, 2017

Uh oh!

asfbot commented Apr 11, 2017

Build result: FAILURE

Uh oh!

kchilton2 commented Apr 11, 2017

Uh oh!

asfbot commented Apr 11, 2017

Build result: FAILURE

Uh oh!

asfbot commented Apr 11, 2017

Build result: FAILURE

Uh oh!

amihalik commented Apr 12, 2017

Uh oh!

asfbot commented Apr 12, 2017

Build result: ABORTED

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone