Skip to content

RYA-358 Added checkstyle policy to build and fixed problems.#244

Closed
jdasch wants to merge 1 commit intoapache:masterfrom
jdasch:RYA-358
Closed

RYA-358 Added checkstyle policy to build and fixed problems.#244
jdasch wants to merge 1 commit intoapache:masterfrom
jdasch:RYA-358

Conversation

@jdasch
Copy link
Contributor

@jdasch jdasch commented Oct 13, 2017

  • Disabled snapshot repos since there are no snapshot dependencies.

Description

A number of classes use incorrect imports.

  • Added a checkstyle policy that fails the build if incorrect import statements are used
  • Fixed existing checkstyle violations.
  • Disabled third party snapshot repositories since this project has no third party snapshot dependencies. This will reduce the number of unnecessary http requests a build will require in some scenarios.

Tests

N/A

Links

Jira RYA-358

Checklist

  • Code Review
  • Squash Commits

People To Reivew

@meiercaleb
@amihalik

- Disabled snapshot repos since there are no snapshot dependencies.
@asfgit
Copy link

asfgit commented Oct 13, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/529/

Copy link

@DLotts DLotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe that maven can do this! Thank you @jdasch ! Approved!

@asfgit asfgit closed this in 853e0ee Oct 13, 2017
@jdasch jdasch deleted the RYA-358 branch October 13, 2017 18:08
ejwhite922 pushed a commit to ejwhite922/incubator-rya that referenced this pull request Nov 8, 2017
apache#244.

- Disabled snapshot repos since there are no snapshot dependencies.
DLotts pushed a commit to DLotts/rya that referenced this pull request Nov 21, 2017
apache#244.

- Disabled snapshot repos since there are no snapshot dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants