[SCB-272] Edge find service instances null problem#523
Merged
WillemJiang merged 2 commits intoapache:masterfrom Jan 23, 2018
Merged
[SCB-272] Edge find service instances null problem#523WillemJiang merged 2 commits intoapache:masterfrom
WillemJiang merged 2 commits intoapache:masterfrom
Conversation
WillemJiang
reviewed
Jan 22, 2018
| LOGGER.info("failed to load generic class {}, use {}. cause: {}.", | ||
| rawClassName, | ||
| result.getGenericSignature(), | ||
| e.getMessage()); |
Member
There was a problem hiding this comment.
We can see the stack trace when passing the exception instance into LOGGER. My suggestion is keeping the e there instead of using e.getMessage().
Contributor
Author
There was a problem hiding this comment.
this affect in edge , and almost all generic class not exist, so will print too many stacktrace
in this time , we know what happened and why it happened, so only message is useful
WillemJiang
approved these changes
Jan 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.