Skip to content

[SCB-567] treat warning as errors, modify the compilerArgments#695

Merged
wujimin merged 1 commit intoapache:masterfrom
weichao666:warningaserror
May 10, 2018
Merged

[SCB-567] treat warning as errors, modify the compilerArgments#695
wujimin merged 1 commit intoapache:masterfrom
weichao666:warningaserror

Conversation

@weichao666
Copy link
Copy Markdown
Contributor

@weichao666 weichao666 commented May 9, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 87.331% when pulling c65bcc7 on weichao666:warningaserror into cd87c96 on apache:master.

@weichao666
Copy link
Copy Markdown
Contributor Author

weichao666 commented May 9, 2018

<configuration>
  <compilerArguments>
    <Werror />
    <Xlint:all />
  </compilerArguments>
 </configuration>

cse can't use <Xlint:all />,it will cause error while use python elementTree to parse pom.xml

replace use

<configuration>
  <compilerArgs>
    <arg>-Werror</arg>
    <arg>-Xlint:all</arg>
  </compilerArgs>
</configuration>

@wujimin wujimin merged commit 23d03bc into apache:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants