Skip to content

[SCB-992] Synchronous open source code from Vert.x 3.5.3 version#973

Merged
liubao68 merged 1 commit intoapache:masterfrom
jeho0815:Branch_master_SCB-992
Oct 31, 2018
Merged

[SCB-992] Synchronous open source code from Vert.x 3.5.3 version#973
liubao68 merged 1 commit intoapache:masterfrom
jeho0815:Branch_master_SCB-992

Conversation

@jeho0815
Copy link
Contributor

@jeho0815 jeho0815 commented Oct 29, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68
Copy link
Contributor

Can you discribe what's the problem of this improment? Can't get it from the title

@jeho0815 jeho0815 force-pushed the Branch_master_SCB-992 branch from 936ae7a to a1439fe Compare October 30, 2018 03:48
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 86.334% when pulling a1439fe on jeho0815:Branch_master_SCB-992 into 0daff2e on apache:master.

@jeho0815
Copy link
Contributor Author

jeho0815 commented Oct 30, 2018

Can you discribe what's the problem of this improment? Can't get it from the title

Vertx 3.5.3 BodyHandlerImpl has some changes and bug fixes, such as #789, the most code of RestBodyHandler in ServiceComb is similar with it, so we should synchronous those changes into servicecomb

@liubao68 liubao68 merged commit b1438cd into apache:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants