Skip to content

Conversation

@peng-yongsheng
Copy link
Member

@peng-yongsheng peng-yongsheng commented Mar 11, 2018

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Make check style to be a module. Multimodule Configuration

  • Add scm, licenses, mailing lists into root pom.

@peng-yongsheng peng-yongsheng added core feature Core and important feature. Sometimes, break backwards compatibility. feature New feature labels Mar 11, 2018
@peng-yongsheng peng-yongsheng added this to the 5.0.0-alpha milestone Mar 11, 2018
@peng-yongsheng peng-yongsheng requested a review from wu-sheng March 11, 2018 10:33
wu-sheng
wu-sheng previously approved these changes Mar 11, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.178% when pulling 9d5c67f on peng-yongsheng:feature/stylecheck into 90cab45 on apache:master.

@wu-sheng wu-sheng merged commit 468052c into apache:master Mar 11, 2018
@peng-yongsheng peng-yongsheng deleted the feature/stylecheck branch March 17, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core feature Core and important feature. Sometimes, break backwards compatibility. feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants