Skip to content

STORM-208: Add storm-kafka as an external module#65

Merged
asfgit merged 184 commits intoapache:masterfrom
ptgoetz:storm-kafka-module
Apr 21, 2014
Merged

STORM-208: Add storm-kafka as an external module#65
asfgit merged 184 commits intoapache:masterfrom
ptgoetz:storm-kafka-module

Conversation

@ptgoetz
Copy link
Member

@ptgoetz ptgoetz commented Apr 9, 2014

This adds storm-kafka as an "external" module and incorporates it into the maven build.

This includes the commit history from the original storm-kafka from storm-contrib as well as the commit history from wurstmeister/storm-kafka-0.8-plus.

Aside from build incorporation, bump to kafka 0.8.1, and license headers, the only significant change is to add the topic name to the committed path.

@wurstmeister
Copy link
Contributor

+1

1 similar comment
@nathanmarz
Copy link
Contributor

+1

@ptgoetz
Copy link
Member Author

ptgoetz commented Apr 18, 2014

Any other committers have an opinion on this? I'd like to merge it for the next release.

@d2r
Copy link

d2r commented Apr 18, 2014

Built and ran tests in OSX and linux, from top level and from external/storm-kafka, and everything passes.

When I package it up, I do not see where the kafka classes are being included. How is the packaging done?

@ptgoetz
Copy link
Member Author

ptgoetz commented Apr 18, 2014

@d2r,

Good question. As it stands now in this pull request, the binaries, etc. will be pushed to maven central, and that's it.

For a source distro, the source will be included. For a convenience binary distro, we need to decide what to do. For a binary, distro we need to figure out what to include. I was thinking binary, source, and javadoc jars, as well as the README.

This is a good time to establish a project standard.

@d2r
Copy link

d2r commented Apr 21, 2014

I was thinking binary, source, and javadoc jars, as well as the README.

That sounds reasonable to me,

  • Binary from Maven as its own artifact with binary, source, javadoc jars
  • Binary from the apache site for convenience with the above plus a README
  • Source from the normal storm source distribution, as it is now

Is that right?

@ptgoetz
Copy link
Member Author

ptgoetz commented Apr 21, 2014

@d2r, yes, that's correct. I'll update the build process accordingly.

@ptgoetz
Copy link
Member Author

ptgoetz commented Apr 21, 2014

Updated build to include source, binary, and javadoc jars as well as the README.md file to the external/storm-kafka directory.

@d2r
Copy link

d2r commented Apr 21, 2014

+1

@asfgit asfgit merged commit ae728f8 into apache:master Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants