STORM-208: Add storm-kafka as an external module#65
Conversation
Add a new per-partition and total metric, "earliestTimeOffset"
* added partitions -> task mapping logging
added yourkit acknowledgement
|
+1 |
1 similar comment
|
+1 |
|
Any other committers have an opinion on this? I'd like to merge it for the next release. |
|
Built and ran tests in OSX and linux, from top level and from external/storm-kafka, and everything passes. When I package it up, I do not see where the kafka classes are being included. How is the packaging done? |
|
@d2r, Good question. As it stands now in this pull request, the binaries, etc. will be pushed to maven central, and that's it. For a source distro, the source will be included. For a convenience binary distro, we need to decide what to do. For a binary, distro we need to figure out what to include. I was thinking binary, source, and javadoc jars, as well as the README. This is a good time to establish a project standard. |
That sounds reasonable to me,
Is that right? |
|
@d2r, yes, that's correct. I'll update the build process accordingly. |
|
Updated build to include source, binary, and javadoc jars as well as the README.md file to the |
|
+1 |
This adds storm-kafka as an "external" module and incorporates it into the maven build.
This includes the commit history from the original storm-kafka from storm-contrib as well as the commit history from wurstmeister/storm-kafka-0.8-plus.
Aside from build incorporation, bump to kafka 0.8.1, and license headers, the only significant change is to add the topic name to the committed path.