[SYSTEMML-629] source statement not resolve absolute paths#168
Closed
nishi-t wants to merge 1 commit intoapache:masterfrom
Closed
[SYSTEMML-629] source statement not resolve absolute paths#168nishi-t wants to merge 1 commit intoapache:masterfrom
nishi-t wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Member
|
Tested on Windows. Absolute paths such as "C:\example.dml" work. LGTM I had success with "C:\..." but not absolute paths starting with "\" or "/" (on Windows). We might want to look into updating this in the future. |
Member
|
Just for reference, this pertains to SYSTEMML-626. The header says SYSTEMML-629. |
niketanpansare
pushed a commit
to niketanpansare/systemml
that referenced
this pull request
Jun 9, 2016
Fix source statement to deal with absolute paths. Closes apache#168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch make some minor changes to dml and pydml parser for addressing the issue in JIRA. Please review.