[SYSTEMML-834] Improve MLContext DataFrame support#218
Closed
deroneriksson wants to merge 2 commits intoapache:masterfrom
Closed
[SYSTEMML-834] Improve MLContext DataFrame support#218deroneriksson wants to merge 2 commits intoapache:masterfrom
deroneriksson wants to merge 2 commits intoapache:masterfrom
Conversation
| */ | ||
| public DataFrame asDataFrameDoubleNoIDColumn() { | ||
| DataFrame df = MLContextConversionUtil.matrixObjectToDataFrame(matrixObject, sparkExecutionContext, false); | ||
| df = df.drop("ID"); |
Contributor
There was a problem hiding this comment.
I think we need to sort before dropping the "ID" column to ensure the order is correct, i.e. df = df.sort("ID").drop("ID").
Member
Author
|
@dusenberrymw Added sorts before the drops |
Contributor
|
LGTM. |
Member
Author
|
Thank you for reviewing @dusenberrymw! I will merge. |
j143-zz
pushed a commit
to j143-zz/systemml
that referenced
this pull request
Nov 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for 4 types of DataFrame inputs and outputs via MLContext (doubles with ID column, doubles with no ID column, vectors with ID column, vectors with no ID column).