Skip to content

Comments

[SYSTEMML-902] Improve FrameObject toString output#237

Closed
deroneriksson wants to merge 2 commits intoapache:masterfrom
deroneriksson:SYSTEMML-902-frameobject_tostring
Closed

[SYSTEMML-902] Improve FrameObject toString output#237
deroneriksson wants to merge 2 commits intoapache:masterfrom
deroneriksson:SYSTEMML-902-frameobject_tostring

Conversation

@deroneriksson
Copy link
Member

Override toString for FrameObject, similar to MatrixObject.

Example of outputting MatrixObject and FrameObject via MLContext, before PR:

scala> val res = ml.execute(dmlScript)
res: org.apache.sysml.api.mlcontext.MLResults = 
  [1] (Matrix) tA: Matrix: scratch_space//_p7667_9.31.117.12//_t0/tA_290, [3 x 2, nnz=6, blocks (1000 x 1000)], binaryblock, dirty
  [2] (Frame) tAM: org.apache.sysml.runtime.controlprogram.caching.FrameObject@6c6c4579

After PR:

scala> val res = ml.execute(dmlScript)
res: org.apache.sysml.api.mlcontext.MLResults = 
  [1] (Matrix) tA: Matrix: scratch_space//_p42840_9.31.117.12//_t0/tA_1, [3 x 2, nnz=6, blocks (1000 x 1000)], binaryblock, dirty
  [2] (Frame) tAM: Frame: scratch_space//_p42840_9.31.117.12//_t0/tAM, [3 x 2, nnz=6, blocks (1000 x 1000)], binaryblock, dirty

@deroneriksson
Copy link
Member Author

@mboehm7
Is the conditional "if (_metaData instanceof NumItemsByEachReducerMetaData)" check necessary for frames or can this be removed?

@mboehm7
Copy link
Contributor

mboehm7 commented Sep 9, 2016

no it's not required as frames are not supported in the MR backend yet.

@deroneriksson
Copy link
Member Author

@mboehm7 Thank you

@asfgit asfgit closed this in 6bfccb7 Sep 9, 2016
j143-zz pushed a commit to j143-zz/systemml that referenced this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants