[SYSTEMML-1127] Synchronize creation of the cache directory#295
Closed
fschueler wants to merge 1 commit intoapache:masterfrom
Closed
[SYSTEMML-1127] Synchronize creation of the cache directory#295fschueler wants to merge 1 commit intoapache:masterfrom
fschueler wants to merge 1 commit intoapache:masterfrom
Conversation
This fixes a race condition that occurred while initializing the cache directory on remote spark workers. By synchronizing this, the problem should be resolved.
Member
|
LGTM. Thank you @fschueler! |
Contributor
|
Has the synchronization enabled in other way, than this PR. I believe there is no |
Contributor
|
@j143 yes, I had to change this to make both creation and cleanup robust enough. We now synchronize in parfor workers because multiple setups and cleanup registrations needs to happen atomically. The cleanup is handled via a shutdown hook of the executor process. The relevant commit and jira are here |
j143-zz
pushed a commit
to j143-zz/systemml
that referenced
this pull request
Nov 4, 2017
This fixes a race condition that occurred while initializing the cache directory on remote spark workers. By synchronizing this, the problem should be resolved. Closes apache#295.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a race condition that occurred while initializing the cache directory on remote spark workers. By synchronizing this, the problem should be resolved.
As per @mboehm7 's suggestion I synchronized the creation of the temporary cache directory. Initialization of the cache was already synchronized.