[SYSTEMML-1198] Ensure jar included in Python release artifact

[gweidner]

Added condition in pre_setup.py to match different jar name for release build vs snapshot build.

[gweidner]

A distribution build was tested two ways:

1. Normal development/test build where jar name has -SNAPSHOT. Verified python artifact contained -SNAPSHOT jar.
2. Simulated release build, i.e., removed SNAPSHOT in pom version name. Verified python artifact contained release jar (i.e., jar file without snapshot in name.

[gweidner]

@dusenberrymw @niketanpansare

[gweidner]

Here's link to RC1 artifact which had the issue found during validation testing:
https://dist.apache.org/repos/dist/dev/incubator/systemml/0.12.0-incubating-rc1/systemml-0.12.0-incubating-python.tgz

[gweidner]

It looks like classloader.py might also need similar change:
Line 58: if fnmatch.fnmatch(file, 'systemml-*-incubating-SNAPSHOT.jar'):

[dusenberrymw]

Good find, @gweidner. Can you run a quick matrix example from the Python page in our docs just as a sanity check for the classloader? You'll need to build and then pip install the tar distribution. Nothing extensive, just a simple test.

[niketanpansare]

Thanks @gweidner 👍

[gweidner]

Thank you @dusenberrymw and @niketanpansare for reviewing! I'm attaching screen captures of examples run from Python Notebook where I've uninstalled/re-installed the previous/updated artifact and restarted kernel.

[gweidner]

For reference in case I've mis-interpreted anything, here are examples of error messages observed before making both changes:

[bertholdreinwald]

Hah. I noticed that too by analyzing the different artifacts on apache site and maven site. Sent out an email to dev list prior to reading that thread.