Skip to content

ZEPPELIN-188 Display of line numbers#174

Closed
r-kamath wants to merge 1 commit intoapache:masterfrom
r-kamath:master
Closed

ZEPPELIN-188 Display of line numbers#174
r-kamath wants to merge 1 commit intoapache:masterfrom
r-kamath:master

Conversation

@r-kamath
Copy link
Copy Markdown
Member

Partial check-in with reference to : ZEPPELIN-188.

  • Add an option under the paragraph settings to show/hide line numbers in ace editor

Since Ace editor is already integrated, with minor changes, this patch will get us line numbers. Based on comments, would like to work on improving - syntax highlighting & auto-complete.

Thanks!

Add an option under the paragraph settings to show/hide line numbers in
ace editor
@felixcheung
Copy link
Copy Markdown
Member

is there a way to have this a sticky setting persisted across sections?
is this settable from the interpreter tab?

@r-kamath
Copy link
Copy Markdown
Member Author

r-kamath commented Aug 4, 2015

is there a way to have this a sticky setting persisted across sections?

In 19aecb2 show/hide line number action is in the paragraph settings and is persisted only in the instance where it's turned on.

is this settable from the interpreter tab?

We can have a new option in the Notebook settings to invoke show/hide action for all paragraphs.
notebook-actions

@corneadoug
Copy link
Copy Markdown
Contributor

Current action bar is pretty full right now (and hard to understand)
The less actions buttons, the better

@Leemoonsoo
Copy link
Copy Markdown
Member

This is screenshot comes from this branch
image

@Leemoonsoo
Copy link
Copy Markdown
Member

It looks good to me. It enables display line numbers while it does not change any default behavior. We can still discuss about action button in separate issue.

If there're no more discussions, i'm merging it.

@asfgit asfgit closed this in 6d42af1 Aug 12, 2015
@eranwitkon
Copy link
Copy Markdown

Just found out that when we turn on line number or turn of line numbers it always reset the paragraph title.
selection_014

Now, after adding the line numbers:
selection_015

@eranwitkon
Copy link
Copy Markdown

The problem above is due to the commitParagraph call within $scope.showLineNumbers and $scope.hideLineNumbers

Leemoonsoo pushed a commit to Leemoonsoo/zeppelin that referenced this pull request Sep 17, 2015
Partial check-in with reference to : ZEPPELIN-188.
- Add an option under the paragraph settings to show/hide line numbers in ace editor

Since Ace editor is already integrated, with minor changes, this patch will get us line numbers. Based on comments, would like to work on improving - syntax highlighting & auto-complete.

Thanks!

Author: Renjith Kamath <renjith.kamath@gmail.com>

Closes apache#174 from r-kamath/master and squashes the following commits:

19aecb2 [Renjith Kamath] ZEPPELIN-188 Display of line numbers

(cherry picked from commit 6d42af1)
Signed-off-by: Lee moon soo <moon@apache.org>
mapr-devops pushed a commit to mapr/zeppelin that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants