ZEPPELIN-34 dirty quick fix python indentation problem#36
Closed
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Closed
ZEPPELIN-34 dirty quick fix python indentation problem#36Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
Whitespace is significant for Python, perhaps we shouldn't trim it out at all.
it could be a function definition, a if-else, or anything else. It could also be nested too:
>>> if foo:
... if bar:
... x = 42
... else:
... print foo
There was a problem hiding this comment.
My reading of the code says that it only strips off new line characters and adds them back in. The s.replace() is never added to accumulated string -- just used for testing.
But, you may be right about not using split("\n") above in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest trying to fix https://issues.apache.org/jira/browse/ZEPPELIN-34
I think part of python integration should be refactored some day. because it's not testable.
this is quick dirty fix for ZEPPELIN-34.