Skip to content

ZEPPELIN-34 dirty quick fix python indentation problem#36

Closed
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo:ZEPPELIN-34
Closed

ZEPPELIN-34 dirty quick fix python indentation problem#36
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo:ZEPPELIN-34

Conversation

@Leemoonsoo
Copy link
Copy Markdown
Member

This pullrequest trying to fix https://issues.apache.org/jira/browse/ZEPPELIN-34
I think part of python integration should be refactored some day. because it's not testable.
this is quick dirty fix for ZEPPELIN-34.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace is significant for Python, perhaps we shouldn't trim it out at all.

it could be a function definition, a if-else, or anything else. It could also be nested too:

>>> if foo:
...     if bar:
...         x = 42
... else:
...   print foo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reading of the code says that it only strips off new line characters and adds them back in. The s.replace() is never added to accumulated string -- just used for testing.

But, you may be right about not using split("\n") above in the code.

@Leemoonsoo Leemoonsoo closed this Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants